-
Notifications
You must be signed in to change notification settings - Fork 17
Include mpy-cross '__init__.py' In Packages; Restructure Package Bundling #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please don't merge yet. @jedgarpark brought up an issue with This PR doesn't fix it either, so I'll add it here. |
Ok, reworked file selection when building the file list. It now includes package subfolders ( A side effect of this change, is that example subfolders are also included, but not annotated with the library name. Currently only one repo has example subfolders: LSM303. This requires a much larger change, and falls in line with #28.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
What triggers the creation of a new library bundle? I thought they might just be periodic but the dates aren't regular so it suggests there's perhaps a (rate limiited?) change based approach here? Is there a way to manually request a new bundle release to pick up the effects of this (non-library) change? |
Just seen a new bundle so please ignore the previous comment or thank-you for prodding it, |
Fixes Enable mpy-cross compilation of some/all __init__.py files in libraries #29, by removing the exclusion of compiling
__init__.py
with mpy-cross, for packaged libraries. Zero-byte files are still excluded.Partially fixes Fix Repo Artifacts in '/lib/' #30:
package_folder_prefix
to use for determining which folder(s) to include with packaged libraries. This changes from an exclusive approach to an inclusive approach, while still allowing some flexibility. (could be expanded to use a list of prefixes in the future)examples
to pass through..travis.yml
directives to include the prefix string (I usedadafruit_
in my testing)